Skip to content

Don't duplicate builtin "once" #71125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Conversation

meg-gupta
Copy link
Contributor

@meg-gupta meg-gupta commented Jan 24, 2024

Fixes rdar://121485860

We can clone builtin "once" instructions that produce Builtin.SILToken. We can't allow phis to be created for these values as defined by SILVerifier::isLegalSILTokenProducer

@meg-gupta meg-gupta changed the title Prevent sinkAddressProjections from creating phis of type Builtin.SILToken Don't duplicate builtin "once" Jan 24, 2024
Fixes rdar://121485860
Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@meg-gupta
Copy link
Contributor Author

@swift-ci test

@meg-gupta meg-gupta enabled auto-merge January 24, 2024 22:41
@meg-gupta meg-gupta merged commit c3c7465 into swiftlang:main Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants