Skip to content

[builds] Build swift-format as part of mixin_linux_installation #71130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jan 24, 2024

We need swift-format to be installed in the toolchain in order to run SourceKit-LSP tests that invoke the swift-format executable.

rdar://121548636

@ahoppen ahoppen requested a review from bnbarham January 24, 2024 23:07
@ahoppen
Copy link
Member Author

ahoppen commented Jan 24, 2024

@swift-ci Please smoke test

Copy link
Contributor

@bnbarham bnbarham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not also want it in base? I think you did the same thing I did, which was to assume that base was used by all. There are many where it isn't. Are there any sourcekit-lsp's left without a swiftformat?

We need swift-format to be installed in the toolchain in order to run SourceKit-LSP tests that invoke the swift-format executable.

rdar://121548636
@ahoppen ahoppen force-pushed the ahoppen/build-swift-format branch from 6234643 to 350b110 Compare January 25, 2024 01:41
@ahoppen ahoppen changed the title [builds] Build swift-format as part of buildbot_linux_base [builds] Build swift-format as part of mixin_linux_installation Jan 25, 2024
@ahoppen
Copy link
Member Author

ahoppen commented Jan 25, 2024

Ah, damn. I meant to add it to mixin_linux_installation, which buildbot_linux_base inherits from.

@ahoppen
Copy link
Member Author

ahoppen commented Jan 25, 2024

@swift-ci Please smoke test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants