NFC: [MemAccessUtils] Tweaked API. #71157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `visitProductLeafAccessPathNodes` required its caller to provide both an `AccessPath` `path` and an `SILValue` `address` which satisfied `path == AccessPath::compute(address)` to force the caller to handle the case of an invalid `AccessPath`. Now, instead, it computes the value itself and returns false if it's invalid. It could be tweaked to also return false if the provided lambda returned false but that would make the only currently extant callers less pleasant and also would not be sufficient in the case of caller who wanted to distinguish between an invalid `AccessPath` and a particular leaf visit returning false.
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
visitProductLeafAccessPathNodesrequired its caller to provide both anAccessPathpathand anSILValueaddresswhich satisfiedpath == AccessPath::compute(address)to force the caller to handle the case of an invalidAccessPath. Now, instead, it computes the value itself and returns false if it's invalid.It could be tweaked to also return false if the provided lambda returned false but that would make the only currently extant callers less pleasant and also would not be sufficient in the case of caller who wanted to distinguish between an invalid
AccessPathand a particular leaf visit returning false.