Skip to content

[stdlib] Resolve unsafeBitCast warnings in Runtime.swift.gyb. #7116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2017
Merged

[stdlib] Resolve unsafeBitCast warnings in Runtime.swift.gyb. #7116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 25 additions & 33 deletions stdlib/public/core/Runtime.swift.gyb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,11 @@ import SwiftShims
// Atomics
//===----------------------------------------------------------------------===//

public typealias _PointerToPointer = UnsafeMutablePointer<UnsafeRawPointer?>

@_transparent
public // @testable
func _stdlib_atomicCompareExchangeStrongPtr(
object target: _PointerToPointer,
expected: _PointerToPointer,
object target: UnsafeMutablePointer<UnsafeRawPointer?>,
expected: UnsafeMutablePointer<UnsafeRawPointer?>,
desired: UnsafeRawPointer?) -> Bool {

// We use Builtin.Word here because Builtin.RawPointer can't be nil.
Expand Down Expand Up @@ -71,11 +69,16 @@ public // @testable
func _stdlib_atomicCompareExchangeStrongPtr<T>(
object target: UnsafeMutablePointer<UnsafeMutablePointer<T>${optional}>,
expected: UnsafeMutablePointer<UnsafeMutablePointer<T>${optional}>,
desired: UnsafeMutablePointer<T>${optional}) -> Bool {
desired: UnsafeMutablePointer<T>${optional}
) -> Bool {
let rawTarget = UnsafeMutableRawPointer(target).assumingMemoryBound(
to: Optional<UnsafeRawPointer>.self)
let rawExpected = UnsafeMutableRawPointer(expected).assumingMemoryBound(
to: Optional<UnsafeRawPointer>.self)
return _stdlib_atomicCompareExchangeStrongPtr(
object: unsafeBitCast(target, to: _PointerToPointer.self),
expected: unsafeBitCast(expected, to: _PointerToPointer.self),
desired: unsafeBitCast(desired, to: Optional<UnsafeRawPointer>.self))
object: rawTarget,
expected: rawExpected,
desired: UnsafeRawPointer(desired))
}
% end # optional

Expand All @@ -87,10 +90,10 @@ func _stdlib_atomicInitializeARCRef(
desired: AnyObject) -> Bool {
var expected: UnsafeRawPointer?
let desiredPtr = Unmanaged.passRetained(desired).toOpaque()
let rawTarget = UnsafeMutableRawPointer(target).assumingMemoryBound(
to: Optional<UnsafeRawPointer>.self)
let wonRace = _stdlib_atomicCompareExchangeStrongPtr(
object: unsafeBitCast(target, to: _PointerToPointer.self),
expected: &expected,
desired: desiredPtr)
object: rawTarget, expected: &expected, desired: desiredPtr)
if !wonRace {
// Some other thread initialized the value. Balance the retain that we
// performed on 'desired'.
Expand Down Expand Up @@ -223,25 +226,14 @@ public func _swift_stdlib_atomicLoadInt(
#endif
}

@_transparent
public // @testable
func _swift_stdlib_atomicLoadPtrImpl(
object target: UnsafeMutablePointer<OpaquePointer>
) -> OpaquePointer? {
let value = Builtin.atomicload_seqcst_Word(target._rawValue)
return OpaquePointer(bitPattern: Int(value))
}

@_transparent
public // @testable
func _stdlib_atomicLoadARCRef(
object target: UnsafeMutablePointer<AnyObject?>
) -> AnyObject? {
let result = _swift_stdlib_atomicLoadPtrImpl(
object: unsafeBitCast(target, to: UnsafeMutablePointer<OpaquePointer>.self))
if let unwrapped = result {
return Unmanaged<AnyObject>.fromOpaque(
UnsafePointer(unwrapped)).takeUnretainedValue()
let value = Builtin.atomicload_seqcst_Word(target._rawValue)
if let unwrapped = UnsafeRawPointer(bitPattern: Int(value)) {
return Unmanaged<AnyObject>.fromOpaque(unwrapped).takeUnretainedValue()
}
return nil
}
Expand All @@ -251,17 +243,17 @@ func _stdlib_atomicLoadARCRef(
public func _swift_stdlib_atomicFetch${operation}Int(
object target: UnsafeMutablePointer<Int>,
operand: Int) -> Int {
let rawTarget = UnsafeMutableRawPointer(target)
#if arch(i386) || arch(arm)
return Int(Int32(bitPattern:
_swift_stdlib_atomicFetch${operation}UInt32(
object: unsafeBitCast(target, to: UnsafeMutablePointer<UInt32>.self),
operand: UInt32(bitPattern: Int32(operand)))))
let value = _swift_stdlib_atomicFetch${operation}Int32(
object: rawTarget.assumingMemoryBound(to: Int32.self),
operand: Int32(operand))
#elseif arch(x86_64) || arch(arm64) || arch(powerpc64) || arch(powerpc64le) || arch(s390x)
return Int(Int64(bitPattern:
_swift_stdlib_atomicFetch${operation}UInt64(
object: unsafeBitCast(target, to: UnsafeMutablePointer<UInt64>.self),
operand: UInt64(bitPattern: Int64(operand)))))
let value = _swift_stdlib_atomicFetch${operation}Int64(
object: rawTarget.assumingMemoryBound(to: Int64.self),
operand: Int64(operand))
#endif
return Int(value)
}
% end

Expand Down