Prevent crash with -playground when -experimental-skip-non-inlinable-function-bodies-without-types also passed
#71171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abertelrud
requested review from
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
…le-function-bodies-without-types` also passed Skip playground transform for functions that have skipped bodies. This can happen when passing `-emit-module` and `-experimental-skip-non-inlinable-function-bodies-without-types` and also enabling the playground transform. This causes the type to be `nullptr`. The fix is for the playground transform to check `AbstractFunctionDecl::isBodySkipped()`. rdar://119258854
abertelrud
force-pushed
the
abertelrud/119258854-playground-crash-on-skipped-function-bodies
branch
from
7ee878b to
690568d
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
|
@slavapestov or @hborla or @xedin: any concerns with this? In addition to the unit test, I have tested locally with a compiler root. I have checked that this change addresses the problem for the case in which this was reported, and that it doesn't seem to negatively affect generating playground results elsewhere. (I'm asking you three specifically as GitHub suggested you as reviewers). |
hborla
approved these changes
Jan 30, 2024
abertelrud
deleted the
abertelrud/119258854-playground-crash-on-skipped-function-bodies
branch
|
Thanks for the review and approval! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip playground transform for functions that have skipped bodies.
Discussion
This can happen when passing
-emit-moduleand-experimental-skip-non-inlinable-function-bodies-without-typesand also enabling the playground transform. This causes the type to benullptr. The fix is for the playground transform to checkAbstractFunctionDecl::isBodySkipped().Changes
isBodySkippedrdar://119258854