SIL: add the borrowed-from instruction #71176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeckstein
force-pushed
the
borrowed-from-instruction
branch
2 times, most recently
from
898c0c0 to
fad94c6
Compare
eeckstein
force-pushed
the
borrowed-from-instruction
branch
from
fad94c6 to
daa7bc7
Compare
eeckstein
force-pushed
the
borrowed-from-instruction
branch
3 times, most recently
from
a2f9dc7 to
237bd40
Compare
|
@swift-ci test |
|
@swift-ci test |
eeckstein
force-pushed
the
borrowed-from-instruction
branch
2 times, most recently
from
2955436 to
973467f
Compare
|
@swift-ci benchmark |
eeckstein
force-pushed
the
borrowed-from-instruction
branch
from
973467f to
a1d9657
Compare
eeckstein
force-pushed
the
borrowed-from-instruction
branch
from
a1d9657 to
9ddaf33
Compare
|
@swift-ci test |
meg-gupta
reviewed
Apr 9, 2024
| (``%1``). | ||
| In case of an adjacent phi, all incoming values of the adjacent phi must be | ||
| borrow introducers for the corresponding incoming value of the borrowed | ||
| operand in all predecessor blocks. |
There was a problem hiding this comment.
While working on guaranteed phis, I think I encountered some cases where enclosing value could be adjacent or dominating. Does the borrowed from insertion pass handle when this can happen ?
There was a problem hiding this comment.
I'm not sure what you mean exactly. Yes, the enclosing values (= the operands after from) can be an adjacent phis or dominating borrow introducers.
This is computed iteratively (until convergence) from incoming values in predcessors
…a reverse dependency
It declares from which enclosing values a guaranteed phi argument is borrowed from.
Compute, update and handle borrowed-from instruction in various utilities and passes. Also, used borrowed-from to simplify `gatherBorrowIntroducers` and `gatherEnclosingValues`. Replace those utilities by `Value.getBorrowIntroducers` and `Value.getEnclosingValues`, which return a lazily computed Sequence of borrowed/enclosing values.
eeckstein
force-pushed
the
borrowed-from-instruction
branch
from
9ddaf33 to
e14c1d1
Compare
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The borrowed-from instruction declares from which enclosing values a guaranteed phi argument is borrowed from. For example:
An enclosing value is either a dominating borrow introducer of the borrowed operand (
%3) or an adjacent phi-argument in the same block (%4).So far, this information was computed dynamically by ownership utilities (e.g.
gatherEnclosingValues). With the borrowed-from instructions those utilities get dramatically simpler.The borrowed-from instruction is similar in spirit to phi-nodes in plain SSA: it "caches" information from predecessor blocks so that optimization passes can easily access this information. If an optimization pass introduces a new guaranteed phi argument it can use the
BorrowedFromUpdaterto generate the required borrowed-from instructions. This is similar toSSAUpdaterwhich inserts required phi-nodes.Beside simplifying the ownership utilities, it's also useful that the adjacent phi relations are now explicitly visible in SIL.
Another nice thing is that this change is (almost) a pure addition to SIL. This means that the existing C++ ownership utilities still work - with and without inserted borrowed-from instructions. The only exception is that they have to look through borrowed-from instructions in some places.