Improve swift caching tests #71200
Merged
Improve swift caching tests #71200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
cachemeifyoucan
force-pushed
the
eng/PR-swift-caching-tests-improvements
branch
from
755aec3 to
06249d1
Compare
|
@swift-ci please smoke test |
cachemeifyoucan
force-pushed
the
eng/PR-swift-caching-tests-improvements
branch
from
06249d1 to
1cf80d1
Compare
|
@swift-ci please smoke test |
cachemeifyoucan
force-pushed
the
eng/PR-swift-caching-tests-improvements
branch
from
1cf80d1 to
a30d58a
Compare
|
@swift-ci please smoke test |
Improve caching related tests to make them faster and test the situation closer to what actually happens during explicit module build. Most noticable changes are: * Avoid swift stdlib dependency during the tests to save time * Use dependency scanner output to construct test cases * Update old test cases that try to simulate caching from file system inputs to using only CAS inputs.
Remove `-allow-unstable-cache-key-for-testing` frontend flag. It is a test only flag when the infrastructure is not ready to write tests for fully cachable tasks. It is no longer needed after all the related tests are rewritten to use dependency scanner.
cachemeifyoucan
force-pushed
the
eng/PR-swift-caching-tests-improvements
branch
from
a30d58a to
f3c5e6a
Compare
|
@swift-ci please smoke test |
|
Verified that none of the CAS test show up in the slowest tests anymore (that is longer than 50s). |
|
ping |
artemcm
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve caching related tests to make them faster and test the situation
closer to what actually happens during explicit module build. Most
noticable changes are:
* Avoid swift stdlib dependency during the tests to save time
* Use dependency scanner output to construct test cases
* Update old test cases that try to simulate caching from file system
inputs to using only CAS inputs.