-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Add i686-unknown-windows-coff
/x86_64-unknown-windows-coff
embedded triples
#71203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
These triples don't need additional adjustments in the standard library and complement existing embedded triples for i686 and x86_64 CPU architectures.
@swift-ci test |
@swift-ci build toolchain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to not prefer the unknown
vendor? Do you intend to have vendor specific extensions in this context? Otherwise, I think that x86_64-unknown-windows-coff
would be better (basically removes the assumption that you have the MS ABI or MSVC available). I would recommend that a comment explaining why the OS is specified in these triples.
@swift-ci build toolchain |
@swift-ci test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a reasonable way forward, it really is unfortunate that LLVM doesn't support a freestanding COFF environment (but I expect that is more to do with the fact that there are errant checks for OS vs file formats).
i686-pc-windows-coff
/x86_64-pc-windows-coff
embedded triplesi686-unknown-windows-coff
/x86_64-unknown-windows-coff
embedded triples
FWIW I found many similar issues with |
These triples don't need additional adjustments in the standard library and complement existing embedded triples for i686 and x86_64 CPU architectures.
Ideally, this would allow compiling Embedded Swift code for Windows without MSVC more easily.