Skip to content

Large loadable types peepholes and address assignment #71215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Large loadable types peepholes and address assignment #71215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions include/swift/AST/IRGenOptions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,6 +404,9 @@ class IRGenOptions {
/// using TypeInfo entries.
unsigned ForceStructTypeLayouts : 1;

/// Run a reg2Mem pass after large loadable type lowering.
unsigned EnableLargeLoadableTypesReg2Mem : 1;

/// Enable generation and use of layout string based value witnesses
unsigned EnableLayoutStringValueWitnesses : 1;

Expand Down Expand Up @@ -537,6 +540,7 @@ class IRGenOptions {
CompactAbsoluteFunctionPointer(false), DisableLegacyTypeInfo(false),
PrespecializeGenericMetadata(false), UseIncrementalLLVMCodeGen(true),
UseTypeLayoutValueHandling(true), ForceStructTypeLayouts(false),
EnableLargeLoadableTypesReg2Mem(true),
EnableLayoutStringValueWitnesses(false),
EnableLayoutStringValueWitnessesInstantiation(false),
EnableObjectiveCProtocolSymbolicReferences(true),
Expand Down
6 changes: 6 additions & 0 deletions include/swift/Option/FrontendOptions.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1070,6 +1070,12 @@ def force_struct_type_layouts : Flag<["-"], "force-struct-type-layouts">,
def enable_layout_string_value_witnesses : Flag<["-"], "enable-layout-string-value-witnesses">,
HelpText<"Enable layout string based value witnesses">;

def enable_large_loadable_types_reg2mem : Flag<["-"], "enable-large-loadable-types-reg2mem">,
HelpText<"Enable large loadable types register to memory pass">;

def disable_large_loadable_types_reg2mem : Flag<["-"], "disable-large-loadable-types-reg2mem">,
HelpText<"Disable large loadable types register to memory pass">;

let Flags = [FrontendOption, NoDriverOption, HelpHidden, ModuleInterfaceOptionIgnorable] in {
def enable_pack_metadata_stack_promotion :
Joined<["-"], "enable-pack-metadata-stack-promotion=">,
Expand Down
5 changes: 4 additions & 1 deletion lib/Frontend/CompilerInvocation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3009,7 +3009,10 @@ static bool ParseIRGenArgs(IRGenOptions &Opts, ArgList &Args,
Args.hasFlag(OPT_enable_relative_protocol_witness_tables,
OPT_disable_relative_protocol_witness_tables,
Opts.UseRelativeProtocolWitnessTables);

Opts.EnableLargeLoadableTypesReg2Mem =
Args.hasFlag(OPT_enable_large_loadable_types_reg2mem,
OPT_disable_large_loadable_types_reg2mem,
Opts.EnableLargeLoadableTypesReg2Mem);
Opts.EnableLayoutStringValueWitnesses = Args.hasFlag(OPT_enable_layout_string_value_witnesses,
OPT_disable_layout_string_value_witnesses,
Opts.EnableLayoutStringValueWitnesses);
Expand Down
Loading