[embedded] Fix calling convention on embedded runtime APIs (switch @_silgen_name for @_cdecl) #71226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…silgen_name for @_cdecl)
kubamracek
requested review from
phausler,
mikeash,
al45tair,
rauhul,
zoecarver and
eeckstein
|
@swift-ci please test |
al45tair
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had
@_silgen_name-annotated runtime APIs in the embedded Swift runtime, which is a mismatched calling convention on the SIL level,@convention(thin)vs@convention(c), as well as the LLVM IR level,swiftccvs noswiftcc. In most cases this doesn't matter, but there is one case where it does, it's described in the attached testcase and involves LTO, and results in a miscompile (LLVM optimizer turns the runtime API call into an unconditional trap). Let's fix that by using@_extern(c), and@_cdeclon APIs that are expected to follow the C calling convention (non swiftcc).rdar://121672536