[cxx-interop] Make automatic conformances work with the bridging header #71243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/std-vector-bridging-header
branch
from
5fc27fe to
5c5e993
Compare
|
@swift-ci please smoke test |
For C++ types that are defined in the bridging header, or are `#include`-d from the bridging header, we did not generate the automatic conformances to `CxxSequence`, `CxxRandomAccessCollection` protocols. To check whether we should try to conform a C++ type to those protocols, the compiler checks for the presence of `requires cplusplus` in the module declaration in a modulemap file. This check is there to prevent us from accidentally pulling in `Cxx`/`CxxStdlib` modules when a client is importing a C library. This change makes sure those conformances are generated. rdar://121927459
egorzhdan
force-pushed
the
egorzhdan/std-vector-bridging-header
branch
from
5c5e993 to
c26fe86
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For C++ types that are defined in the bridging header, or are
#include-d from the bridging header, we did not generate the automatic conformances toCxxSequence,CxxRandomAccessCollectionprotocols.To check whether we should try to conform a C++ type to those protocols, the compiler checks for the presence of
requires cplusplusin the module declaration in a modulemap file. This check is there to prevent us from accidentally pulling inCxx/CxxStdlibmodules when a client is importing a C library.This change makes sure those conformances are generated.
rdar://121927459