Skip to content

Fix nondeterminism in explicitly-specified generic macro arguments #71253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DougGregor
Copy link
Member

A hash table got flattened into an array without any ordering guarantees, and then we assumed it was in order. Fixes rdar://121397992.

A hash table got flattened into an array without any ordering guarantees,
and then we assumed it was in order. Fixes rdar://121397992.
@DougGregor
Copy link
Member Author

@swift-ci please smoke test

@DougGregor DougGregor enabled auto-merge January 30, 2024 20:41
Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great catch -- thanks!

@DougGregor DougGregor merged commit 29cfe61 into swiftlang:main Jan 30, 2024
@DougGregor DougGregor deleted the hash-table-iteration-considered-harmful branch January 30, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants