[Caching] Fix versioned canImport check for swift module #71260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the ExplicitCASModuleLoader check for if `canImport` works for a specific swift module. It was mistakenly using the clang caching schema to load the underlying module but in reality, it should only load swift module with swift caching schema. In future, we should let dependency scanner to report version/underlying version for the modules it enounters so the versioned canImport check doesn't need to load and parse the module/TBD file to figure out if the check is successful or not. rdar://120554271
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
artemcm
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the ExplicitCASModuleLoader check for if
canImportworks for a specific swift module. It was mistakenly using the clang caching schema to load the underlying module but in reality, it should only load swift module with swift caching schema.In future, we should let dependency scanner to report version/underlying version for the modules it enounters so the versioned canImport check doesn't need to load and parse the module/TBD file to figure out if the check is successful or not.
rdar://120554271