Skip to content

Parse _borrowing x in patterns as a borrow binding. #71263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2024
Merged

Parse _borrowing x in patterns as a borrow binding. #71263

merged 1 commit into from
Jan 31, 2024

Conversation

jckarter
Copy link
Contributor

Treat it as a contextual keyword when followed by an identifier, like our other ownership-related declarations and operators.

@jckarter
Parse _borrowing x in patterns as a borrow binding.
6706fea 
Treat it as a contextual keyword when followed by an identifier, like our
other ownership-related declarations and operators.
@jckarter
Copy link
Contributor Author

@swift-ci Please test

1 similar comment
@jckarter
Copy link
Contributor Author

@swift-ci Please test

@jckarter jckarter merged commit a52e96e into swiftlang:main Jan 31, 2024
ahoppen
ahoppen reviewed Jan 31, 2024
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs a corresponding change to the parser in swift-syntax as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen ahoppen left review comments

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

@CodaFi CodaFi Awaiting requested review from CodaFi CodaFi is a code owner

@DougGregor DougGregor Awaiting requested review from DougGregor DougGregor is a code owner

@hamishknight hamishknight Awaiting requested review from hamishknight hamishknight is a code owner

@rintaro rintaro Awaiting requested review from rintaro rintaro is a code owner

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

@tshortli tshortli Awaiting requested review from tshortli tshortli is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jckarter @ahoppen