Extend PreModuleImportCallback to support bridging header compilation #71318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian-prantl
requested review from
zoecarver,
hyp,
egorzhdan,
hborla,
slavapestov and
xedin
as code owners
adrian-prantl
requested review from
chelcassanova,
medismailben and
JDevlieghere
and removed request for
xedin,
slavapestov,
hyp,
egorzhdan,
hborla and
zoecarver
|
test with swiftlang/llvm-project#8103 |
chelcassanova
approved these changes
Feb 1, 2024
kastiglione
reviewed
Feb 1, 2024
adrian-prantl
force-pushed
the
bridging-header-progress
branch
3 times, most recently
from
01429f8 to
132ceab
Compare
|
@swift-ci test |
|
@swift-ci smoke test |
kastiglione
approved these changes
Feb 1, 2024
adrian-prantl
force-pushed
the
bridging-header-progress
branch
from
132ceab to
c6c688c
Compare
|
@swift-ci smoke test |
|
Great! LGTM! |
medismailben
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.