Rename @isolated in the SIL sense to @sil_isolated
#71333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmccall
requested review from
AnthonyLatsis,
hborla,
slavapestov,
xedin and
tshortli
as code owners
|
@swift-ci Please smoke test |
rjmccall
force-pushed
the
rename_sil_isolated
branch
from
53788bc to
6de0fba
Compare
|
@swift-ci Please smoke test and merge |
gottesmm
approved these changes
Feb 2, 2024
rjmccall
force-pushed
the
rename_sil_isolated
branch
from
6de0fba to
9e86498
Compare
rjmccall
requested review from
ahoppen,
bnbarham,
CodaFi,
hamishknight and
rintaro
as code owners
rjmccall
force-pushed
the
rename_sil_isolated
branch
from
9e86498 to
cf6f04f
Compare
|
@swift-ci Please smoke test and merge |
rjmccall
force-pushed
the
rename_sil_isolated
branch
from
cf6f04f to
f7052ce
Compare
|
@swift-ci Please smoke test and merge |
|
@swift-ci Please smoke test Linux |
|
@swift-ci Please smoke test macOS |
We want to use @isolated in ordinary Swift, and while we could probably make it coexist with this SIL use, doing so would be really inconvenient.
rjmccall
force-pushed
the
rename_sil_isolated
branch
from
f7052ce to
dd90ae7
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're anticipating using this spelling in Swift for
@isolated(any),@isolated(caller), and maybe others in the future, and it's really inconvenient to be using it in SIL in overlapping positions but with a different interpretation and formation rules.