Protect the add_dependencies calls against non-existent targets
#71348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The install target is sometimes the `None` target, which doesn't actually exist. This should perhaps be spelled `never_install` instead, but given that these are random names, we should protect the `add_dependencies` calls to only accept install components that actually exist.
|
@swift-ci please test |
drodriguez
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The install target is sometimes the
Nonetarget, which doesn't actually exist. This should perhaps be spellednever_installinstead, but given that these are random names, we should protect theadd_dependenciescalls to only accept install components that actually exist.Fixes: rdar://122194103