[Debug] Fix regex type names in DebugDescriptionMacro #71379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
| @@ -71,15 +71,19 @@ extension DebugDescriptionMacro: MemberAttributeMacro { | |||
| return [] | |||
| } | |||
|
|
|||
| // Warning: To use a backslash escape in `typeIdentifier`, it needs to be double escaped. This is because | |||
| // the string is serialized to a String literal (an argument to `@_DebugDescriptionProperty`), which | |||
| // effectively "consumes" one level of escaping. To avoid mistakes, dots are matched with `[.]` instead | |||
There was a problem hiding this comment.
So a . inside of a character enumeration [] does not match any character?
There was a problem hiding this comment.
Apparently.
echo 'Hello. World.' | sed -e 's/[.]/!/g'
Hello! World!
There was a problem hiding this comment.
Yes, character classes match their contents literally (generally speaking, there could be some exceptions I am unaware of). This works for other metacharacters too, ex [+], [$], etc.
There was a problem hiding this comment.
This kind of usage is used as an alternative to backslash escaping.
adrian-prantl
approved these changes
Feb 5, 2024
kastiglione
deleted the
dl/Debug-Fix-regex-type-names-in-DebugDescriptionMacro
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the way
DebugDescriptionMacroproduces a regex type name.The problem was use of backslash escapes that weren't sufficiently escaped. They needed to be double escaped. To avoid this trap, the regexes now use
[.]to match a dot, instead of the more conventional\.syntax.