Serialize fewer archetypes and tidy up casts #7139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Storing this separately is unnecessary since we already serialize the enum element's interface type. Also, this eliminates one of the few remaining cases where we serialize archetypes during AST serialization.
…eBase}::getKind() Also add some FIXMEs for some code in debug info emission that looks incorrect.
|
@swift-ci Please smoke test |
slavapestov
commented
Jan 30, 2017
| /// LValues, inout args, and Archetypes are implicitly indirect by | ||
| /// virtue of their DWARF type. | ||
| // | ||
| // FIXME: Should this check if the lowered SILType is address only |
There was a problem hiding this comment.
@adrian-prantl What do you think? Should we be checking the SIL type lowering instead?
Also class-bound archetypes are not passed indirectly, so it's wrong in that case too.
There was a problem hiding this comment.
Yes, please go ahead.
There was a problem hiding this comment.
How can I construct a test case to verify my hypothesis? I don't want to start blindly changing this stuff without understanding what's going on :)
slavapestov
commented
Jan 30, 2017
| @@ -3278,9 +3278,13 @@ void IRGenSILFunction::visitDebugValueAddrInst(DebugValueAddrInst *i) { | |||
| auto RealType = SILTy.getSwiftType(); | |||
| // Unwrap implicitly indirect types and types that are passed by | |||
| // reference only at the SIL level and below. | |||
| // | |||
| // FIXME: Should this check if the lowered SILType is address only | |||
There was a problem hiding this comment.
@adrian-prantl Ditto
|
@swift-ci Please smoke test Linux |
Previously, hasArgumentType() would silently return false if the EnumElementDecl had not yet been typechecked, but now, getArgumentInterfaceType() asserts in this case. As the FIXME comment suggests, this warrants further investigation, but for now add the workaround.
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.