Skip to content

[embedded] Implicitly define __APPLE__ and __MACH__ when on -apple-none triples, take 2 #71404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[embedded] Implicitly define __APPLE__ and __MACH__ when on -apple-none triples, take 2 #71404

wants to merge 1 commit into from

Conversation

kubamracek
Copy link
Contributor

Attempt 2 to land #71278, which was reverted in #71392.

@kubamracek kubamracek requested review from ktoso, a team, zoecarver, hyp and egorzhdan as code owners February 6, 2024 01:50
compnerd
compnerd approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems identical to the previous iteration.

@kubamracek kubamracek added the embedded Embedded Swift label Apr 22, 2024
@kubamracek
Copy link
Contributor Author

This is now done in LLVM/Clang instead, via llvm/llvm-project#122427

@kubamracek kubamracek closed this Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

@ktoso ktoso Awaiting requested review from ktoso ktoso is a code owner

@zoecarver zoecarver Awaiting requested review from zoecarver zoecarver is a code owner

@hyp hyp Awaiting requested review from hyp

@egorzhdan egorzhdan Awaiting requested review from egorzhdan egorzhdan is a code owner

Assignees
No one assigned
Labels
embedded Embedded Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kubamracek @compnerd