Skip to content

[Macros] Expand nested macros in qualified name lookup. #71407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

hborla
Copy link
Member

@hborla hborla commented Feb 6, 2024

populateLookupTableEntryFromMacroExpansions expands macros that can introduce a given name into the type or extension that we're performing qualified lookup into. However, it only handled one level of macro expansion; it failed to expand any nested macros that can introduce the given name. This change applies the same logic to nested macros to ensure that qualified name lookup doesn't fail when the declaration is produced through several levels of macro expansion.

Resolves rdar://121882362

@hborla
Copy link
Member Author

hborla commented Feb 6, 2024

@swift-ci please smoke test

Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid fix, thanks a lot! LGTM

@ktoso ktoso merged commit 1707e76 into swiftlang:main Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants