[ClangImporter] Import NSNotificationName constants as nonisolated
#71419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
requested review from
ktoso,
zoecarver,
hyp and
egorzhdan
as code owners
|
@swift-ci please test |
|
@swift-ci please test |
These constants could be used with observer APIs from a different isolation context, so it's more convenient to import them as `nonisolated` unless they are explicitly isolated to a MainActor. Resolves: rdar://114052705
beccadax
requested changes
Feb 7, 2024
beccadax
approved these changes
Feb 7, 2024
| @@ -590,6 +590,13 @@ bool importer::isNSString(clang::QualType qt) { | |||
| return qt.getTypePtrOrNull() && isNSString(qt.getTypePtrOrNull()); | |||
| } | |||
|
|
|||
| bool importer::isNSNotificationName(clang::QualType type) { | |||
| if (auto *typealias = type->getAs<clang::TypedefType>()) { | |||
| return typealias->getDecl()->getName() == "NSNotificationName"; | |||
There was a problem hiding this comment.
There's a slight inconsistency with other parts of ClangImporter here—they only treat NSNotifcationName as special if it also (according to retrieveNewTypeAttr()) has a clang::SwiftNewTypeAttr attached. But I think this will only make a difference if the SDK has a broken declaration of NSNotificationName, so it's probably harmless.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These constants could be used with observer APIs from a different isolation
context, so it's more convenient to import them as
nonisolatedunlessthey are explicitly isolated to a MainActor.
Resolves: rdar://114052705