Remove an old restriction on _ObjectiveCBridgeable conformances.
#71426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Historically, we checked against a specific allowlist for a certain set of types that were allowed to introduce an `_ObjectiveCBridgeable` conformance in a different module that where the type was defined. This rigid allow-list isn't really buying us much, but it's getting in the way of some refactoring for swift-foundation that's changing the layering. Remove this diagnostic, since it really isn't buying us much nowadays, and we have the more general warnings about retroactive conformances to make folks think twice.
DougGregor
requested review from
hborla,
xedin,
AnthonyLatsis and
slavapestov
as code owners
|
@swift-ci please smoke test |
parkera
approved these changes
Feb 7, 2024
slavapestov
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically, we checked against a specific allowlist for a certain set of types that were allowed to introduce an
_ObjectiveCBridgeableconformance in a different module that where the type was defined. This rigid allow-list isn't really buying us much, but it's getting in the way of some refactoring for swift-foundation that's changing the layering. Remove this diagnostic, since it really isn't buying us much nowadays, and we have the more general warnings about retroactive conformances to make folks think twice.