-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[region-isolation] Fixes that enable the stdlib to build with region based isolation #71429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….cpp -> VariableNameUtils. I am going to reuse this for TransferNonSendable. In the process I made a few changes to make it more amenable to both use cases and used the current set of tests that we have for noncopyable types to validate that I didn't break anything.
…n possible. A name diagnostic looks as follows: Some notes: 1. VariableNameUtils still doesn't pattern match all cases. In the cases where we fail to pattern match, I fall back to the old diagnostics. I am going to be adding tests/etc specific to VariableNameUtils in a later patch. 2. I took this as an opportunity to begin preparing to change the diagnostics into diags of the following form: a. The main diagnostic is changed to something short "transferring non-Sendable %0 could yield races with later accesses". b. I added a longer note at the same location that explains that our caller is in a specific isolation domain and our callee is isolated differently. c. I added a note on the definition location of the identified value.
… is initialized with a store.
I was correct that it is lookthrough, but it has multiple parameters, so the normal "baked" implementation cannot be used since the "baked" implementation assumes that any insts it handles has a single operand.
…t to ease debugging.
…r, so we need to treat it as a require. We should make this as a transfer... but this is just temporary until I get around to it. For now this is always an out parameter, so we should be safe.
project_box's type is not a box type... it is the type contained in the box.
I thought that we would never actually hit this test case, but since we do not have opaque values this pattern is treated like a projection in certain cases. I updated the code as appropriate and added a test.
Instead treat them as actual results.
@swift-ci smoke test |
This is because in 1e4fe6c, we stopped transfering the function callee as well.
@swift-ci smoke test |
@swift-ci smoke test linux platform |
@swift-ci smoke test macOS platform |
@swift-ci smoke test linux platform |
macOS platform is failing due to something unrelated in IRGen. |
Looks like they all failed:
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decided to use the stdlib to test out region based isolation. Found some issues. They are: