Support class extensions in objcImpl #71445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beccadax
requested review from
hborla,
slavapestov,
xedin,
zoecarver,
hyp and
egorzhdan
as code owners
|
@swift-ci please test |
beccadax
force-pushed
the
category-error
branch
from
e210684 to
c0c45d0
Compare
|
@swift-ci please test |
|
Hmm. On second thought, I bet this needs more work to support conformances... |
This reduces the memory overhead of objcImpl from one word per Decl to one bit per Decl, at the cost of making cache lookups slightly slower (but it will only be consulted once for non-objcImpl decls, which is by far the most common case).
beccadax
force-pushed
the
category-error
branch
from
c0c45d0 to
0453cd3
Compare
An @_objcImpl extension with no category name *should* implement not only the class’s main @interface, but also any class extension @interfaces. Start making this true by making ObjCInterfaceAndImplementationRequest return all of these decls as the interfaces for such an implementation. This commit doesn’t actually change Sema or IRGen to process the extra interfaces, so it’s NFC.
Their requirements are now included when typechecking the main body extension, and their conformances are emitted in IRGen. Fixes rdar://118535473.
beccadax
force-pushed
the
category-error
branch
from
0453cd3 to
68ec6b6
Compare
|
@swift-ci please test |
|
@swift-ci please smoke test compiler performance |
|
@swift-ci please test Windows platform |
|
@tshortli Think you could give this a review? |
tshortli
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Their requirements are now included when typechecking the main body extension.
Fixes rdar://118535473.