Skip to content

Enable colors in FileCheck and Swift tests #71449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 9, 2024

Conversation

hamishknight
Copy link
Contributor

@hamishknight hamishknight commented Feb 7, 2024

If we're attached to a tty, pass --color to FileCheck and --color-diagnostics to Swift invocations in tests.

@hamishknight hamishknight changed the title Enable FileCheck colors by default Enable colors in FileCheck and Swift tests Feb 8, 2024
If we're attached to a tty, pass `--color` to
FileCheck and `--color-diagnostics` to Swift
invocations in tests.
Move the color stream utilities into ColorUtils.h,
and use ColorStream to print diagnostic messages
if `-color-diagnostics` is passed.
@hamishknight
Copy link
Contributor Author

@swift-ci please test

@hamishknight
Copy link
Contributor Author

@swift-ci please Python lint

@hamishknight hamishknight requested a review from gottesmm February 9, 2024 16:59
Copy link
Contributor

@gottesmm gottesmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build-script changes LGTM

@hamishknight hamishknight merged commit bd41dbf into swiftlang:main Feb 9, 2024
@hamishknight hamishknight deleted the filecheck-color branch February 9, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants