[BitwiseCopyable] Don't diagnose implicit checks. #71456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the diagnostics for conforming a non-escaping or non-copyable type to `_BitwiseCopyable` were emitted even in the case of an implicit check for conformance. Here this is fixed to suppress the diagnostics in the case of an implicit check as is done for other diagnostics.
|
@swift-ci please test |
|
@swift-ci Please Build Toolchain macOS Platform |
|
preset=ncgenerics,smoketest=macosx |
nate-chandler
requested review from
hborla,
slavapestov and
xedin
as code owners
nate-chandler
deleted the
bitwise-copyable/implicit-nonescaping-noncopyable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the diagnostics for conforming a non-escaping or non-copyable type to
_BitwiseCopyablewere emitted even in the case of an implicit check for conformance. Here this is fixed to suppress the diagnostics in the case of an implicit check as is done for other diagnostics.