[NFC] BitwiseCopyable: Use getKnownProtocolKind. #71468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It makes sense to form an existential of a type that conforms to `BitwiseCopyable` but such an existential is not itself trivial and consequently not `BitwiseCopyable`.
Rather than getting ahold of the BitwiseCopyable protocol and doing a pointer comparison to another ProtocolDecl, check whether the latter's known protocol kind is ::BitwiseCopyable.
|
@swift-ci please test |
nate-chandler
requested review from
hborla,
slavapestov and
xedin
as code owners
nate-chandler
deleted the
nfc/20240208/1/bitwise-copyable-known-protocol-kind
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than getting ahold of the
BitwiseCopyableprotocol and doing a pointer comparison to anotherProtocolDecl, check whether the latter's known protocol kind is::BitwiseCopyable.