[ExplicitModuleBuild] Add a dependency scanning test for package interface #71476
+39
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
artemcm
approved these changes
Feb 8, 2024
artemcm
reviewed
Feb 8, 2024
| // RUN: -emit-package-module-interface-path %t/Bar.package.swiftinterface | ||
|
|
||
| // RUN: %target-swift-frontend -scan-dependencies -o %t/deps.json -I %t -experimental-package-interface-load \ | ||
| // RUN: %t/Client.swift -module-name Client -package-name barpkg -swift-version 5 |
There was a problem hiding this comment.
Can we add a test that ensures we use the .private. interface if the scanning invocation does not specify -package-name? If that is the expected behavior.
There was a problem hiding this comment.
Done. It does require the experimental flag that took me a while to figure out.
…rface Add a test for dependency scanning for package interface to ensure the correct interface is found when package interface is enabled.
cachemeifyoucan
force-pushed
the
eng/PR-add-scanning-test-for-package-interface
branch
from
40a809f to
0a37b8d
Compare
|
@swift-ci please smoke test |
artemcm
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test for dependency scanning for package interface to ensure the correct interface is found when package interface is enabled.