Skip to content

[Test] Make the ExternalGenericMetadataBuilder test more lenient with equality. #71477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mikeash
Copy link
Contributor

@mikeash mikeash commented Feb 8, 2024

Aspects of the emitted JSON vary depending on the exact contents of the built binaries. This happens when we refer to a private symbol with an offset from a public symbol. The offset and choice of public symbol may vary. Filter these out of the JSON before checking for equality.

… equality.

Aspects of the emitted JSON vary depending on the exact contents of the built binaries. This happens when we refer to a private symbol with an offset from a public symbol. The offset and choice of public symbol may vary. Filter these out of the JSON before checking for equality.
@mikeash mikeash requested a review from al45tair February 8, 2024 19:40
@mikeash
Copy link
Contributor Author

mikeash commented Feb 8, 2024

@swift-ci please test

@mikeash mikeash merged commit 1691786 into swiftlang:main Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant