Sema: Make "@retroactive attribute does not apply" a warning #71498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
tshortli
requested review from
harlanhaskins,
slavapestov,
beccadax and
hborla
and removed request for
xedin,
slavapestov and
hborla
harlanhaskins
approved these changes
Feb 9, 2024
DougGregor
reviewed
Feb 9, 2024
| ERROR(retroactive_attr_does_not_apply,none, | ||
| "'retroactive' attribute does not apply; %0 is declared in this module", | ||
| (Identifier)) | ||
| WARNING(retroactive_attr_does_not_apply,none, |
There was a problem hiding this comment.
This is specified in the proposal to be an error. How about we leave it as an error and use warnUntilSwiftVersion(6) to stage it in?
|
Disabling the auto-merge per Doug’s comment — I’m okay with that but I also understand the urgency with which we need to downgrade this warning |
Follow up to swiftlang#71302. Resolves rdar://122590301
tshortli
force-pushed
the
downgrade-retroactive-does-not-apply-to-warning
branch
from
11b1116 to
a0b4d6d
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #71302.
Resolves rdar://122590301