Sema: track use of public imports by more extensions #71518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
Consider extensions to imported types as users of a public import. This silences false reports of unused public imports in the case of an empty extension satisfying generic requirements via retroactive conformances. It also silences real reports of superfluously public imports used in internal extension, but this isn't very harmful at this time. We should revisit this later and tighten the check, we should refactor the logic use to determine what makes an extension public. rdar://120391841
xymus
force-pushed
the
superfluously-public-import-fixes2
branch
from
5bfbe37 to
e696b5f
Compare
|
@swift-ci Please smoke test |
tshortli
approved these changes
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider extensions to imported types as users of a public import. This silences false reports of unused public imports in the case of an empty extension satisfying generic requirements via retroactive conformances. It also silences real reports of superfluously public imports used in internal extension, but this isn't very harmful at this time.
We should revisit this later and tighten the check, we should refactor the logic use to determine what makes an extension public.
rdar://120391841