[embedded] Update UserManual.md and EmbeddedSwiftStatus.md with some additional information #71523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…additional information
kubamracek
requested review from
phausler,
grynspan,
rauhul,
zoecarver and
eeckstein
|
@swift-ci please smoke test |
rauhul
reviewed
Feb 9, 2024
|
|
||
| ```swift | ||
| func sayHello() { | ||
| #if hasFeature(Embedded) |
There was a problem hiding this comment.
$Embedded; hasFeature doesn't check if the feature is enabled if I recall correctly
There was a problem hiding this comment.
This is an important distinction we should call out because user guidance is to use hasFeature(), not $.
Or maybe there should be a targetEnvironment(embedded) condition.
grynspan
reviewed
Feb 9, 2024
| @@ -10,8 +10,8 @@ For an introduction and motivation into Embedded Swift, please see "[A Vision fo | |||
|
|
|||
| This status table describes which of the following standard library features can be used in Embedded Swift: | |||
|
|
|||
| | **Swift Standard Library Feature** | **Currently Supported In Embedded Swift** | | |||
| |---------------------------------------------|-----------------------------------------------------| | |||
| | **Swift Standard Library Feature** | **Currently Supported In Embedded Swift?** | | |||
There was a problem hiding this comment.
Fun fact, you don't need to pad the columns out. Markdown will render this nicely:
| **Foo** | **Bar** |
|-|-|
| Alpha. | Beta. |
| Gamma delta epsilon eridani. | Live long and prosper. || Foo | Bar |
|---|---|
| Alpha. | Beta. |
| Gamma delta epsilon eridani. | Live long and prosper. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the diff for details.