Ncgenerics test fixes kavon v8 #71540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavon
requested review from
ahoppen,
bnbarham,
hamishknight,
rintaro,
hborla,
xedin,
slavapestov and
tshortli
as code owners
|
@swift-ci please test |
Some tests put no space after `%target-swift-frontend` and the flag that follows it, so we can end up with `-color-diagnostics-emit-module`.
The IDE's use isn't correct under noncopyable generics and only the constraint solver uses it. It's a misleading method now that nearly every archetype has Copyable/Escapable requirements.
We can avoid lookup entirely on invertible protocols because they never can have any members. This saves us from having to update tests and perhaps some extra work in code completion.
Any changes to the order in which lookups happen would require changing all the regression tests.
The missing module was causing not only a crash in conformance lookup, but full qualification for a generic parameter, which shouldn't ever be needed.
With NoncopyableGenerics, most protocols now carry an associated conformance. There's no need to have FileCheck try to assure there isn't any for this test.
I thought this would be simple to add a check for this, but it turns out that a more complete refactoring that eliminates `isNoEscape` in favor of `isEscapable` is most likely needed.
kavon
force-pushed
the
ncgenerics-test-fixes-kavon-v8
branch
from
8fc4283 to
648ac8a
Compare
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more test fixes