Ncgenerics test fixes kavon v9 #71550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I thought it might be impossible to recursively lookupConformance of Copyable, unlike for Sendable. Turns out there are still situations where it can happen, that aren't invalid. This alone fixes `ClangImporter/objc_bridging_generics.swift` and will help reveal any invalid request cycles.
It's not the point of the test.
Noncopyable types cannot be substituted for an unconstrained generic parameter, as it will have a Copyable conformance on it. This test should be refactored to use a concrete function like `transferMoveOnlyStruct` instead of the generic. But its not obvious to me the best way to update this test.
It doesn't make sense that we permit a `ReferenceStorageType` to be substituted for a generic parameter, since I don't know whether any valid Swift code would ever actually construct such SIL. But there are some hand-written SIL test cases that do it anyway, for unconstrained generic parameters. Since now even those get protocol requirements with NoncopyableGenerics, just look at the referent type in ParseSIL.
While this doesn't provde defence agianst incorrect conformance responses in the general case, it should flush out a lot of incorrect ones.
kavon
force-pushed
the
ncgenerics-test-fixes-kavon-v9
branch
from
846a5ad to
32a0ea8
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more test fixes