Sema: ignore inconsistent imports from a file generated by Xcode #71559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Swift 5 mode, the compiler reports when two files import the same module, where one file has a bare import and the other an access-level import. This avoids unintentionally promoting the import to public when preexisting code marked it otherwise. Exempt a file generated by Xcode from this check as it's not user modifiable. In the future, we should identify such generated files properly. Either with a new attribute or in the way they are passed to the compiler. rdar://122032472
|
@swift-ci Please smoke test |
tshortli
approved these changes
Feb 12, 2024
|
@swift-ci Please smoke test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Swift 5 mode, the compiler reports when two different files import the same module, where one file has a default/bare import and the other an access-level import. This prevents unintentionally promoting the import to public when preexisting code marked it otherwise.
Exempt a file generated by Xcode from this check as it's not user modifiable and the generated code cannot know if the rest of the module is using access-level on imports or not. This is an issue only in Swift 5 mode, the import visibility defaulting to internal in Swift 6 mode should handle this use case properly.
In the future, we should identify such generated files properly. Either with a new attribute or in the way they are passed to the compiler.
rdar://122032472