embedded: Fix a few problems with vtable specialization #71579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
eeckstein
force-pushed
the
fix-embedded-classes
branch
from
40aadec to
960a553
Compare
|
@swift-ci test |
eeckstein
force-pushed
the
fix-embedded-classes
branch
from
960a553 to
599da5f
Compare
|
@swift-ci test |
slavapestov
reviewed
Feb 13, 2024
| if (SILType classTy = vtable->getClassType()) { | ||
| superClassTy = classTy.getSuperclass(); | ||
| } else { | ||
| superClassTy = SILType::getPrimitiveObjectType(CanType(vtable->getClass()->getSuperclass())); |
There was a problem hiding this comment.
Is the CanType() guaranteed to succeed? Maybe getCanonicalType() is safer.
If the vtable refers to a specialized class, a SIL type specifies the bound generic class type:
```
sil_vtable $G<Int> {
// ...
}
```
Fixes an IRGen crash if a superclass of a class is generic and not used otherwise. rdar://122405558
…edded stdlib Otherwise derived classes cannot be specialized. Fixes a compile time error when using ManagedBuffer in embedded mode. rdar://122414669
eeckstein
force-pushed
the
fix-embedded-classes
branch
from
599da5f to
75e2f36
Compare
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to specialize tables of superclasses
Fixes an IRGen crash if a superclass of a class is generic and not used otherwise.
rdar://122405558
make the ManagedBuffer initializer public in the embedded stdlib
Otherwise derived classes cannot be specialized.
Fixes a compile time error when using ManagedBuffer in embedded mode.
rdar://122414669
support printing and parsing specialized vtables