[Caching] Do not mix swift modules built from CAS vs. from FileSystem #71586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a different context hash for modules built from caching using CAS vs. normal swift modules. They should not be mixed since those cannot be loaded as a dependencies for a module which is setup to build with a different method. rdar://122814823
cachemeifyoucan
requested review from
akyrtzi,
adrian-prantl,
benlangmuir and
artemcm
|
@swift-ci please smoke test |
adrian-prantl
approved these changes
Feb 16, 2024
The lookup method for external contents are different when using caching. The dependencies with caching have casid inside for dependencies modules which will not work if the compiler instance is not setup with a CAS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a different context hash for modules built from caching using CAS vs. normal swift modules. They should not be mixed since those cannot be loaded as a dependencies for a module which is setup to build with a different method.
rdar://122814823