Add deserialization support for section attribute #71588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternatively, should the |
|
@swift-ci smoke test |
|
@eeckstein is there a convention for testing deserialization? The way I would construct a test is to serialize a swiftmodule containing the section attribute, and then load it from a separate invocation. If the loading crashes, the test fails. |
|
Yes. You can look at some examples in https://github.com/apple/swift/tree/main/test/Serialization, for example https://github.com/apple/swift/blob/main/test/Serialization/attr-extern.swift |
|
@swift-ci test |
|
@swift-ci test linux |
|
@swift-ci test |
|
@swift-ci test macOS |
|
@swift-ci test linux |
|
@swift-ci test macOS |
kastiglione
added a commit
that referenced
this pull request
Feb 21, 2024
Introduces the first use of `@_DebugDescription` in the standard library, applying it to `ObjectIdentifier`. In order to use the DebugDescription macro in the stdlib, the following changes are required: 1. Compilation must reference the just built macros (ie `libSwiftMacros.dylib`), not those from the SDK. This is addressed by adding an explicit `-external-plugin-path` flag that overrides the defaults generated by the compiler (which uses SDK paths, where the macro may or may not exist, and may not be the current version). 2. As DebugDescription uses `@_section`, compilation enables the `SymbolLinkageMarkers` feature. Note that the use of DebugDescription is conditionally enabled for the following reasons: 1. Use is disabled in freestanding builds, where the stdlib macros are not built. 2. Use is temporarily disabled in Linux builds due to a dynamic loader issue that needs further investigation The dynamic loader error causing issues with Linux CI is: > swift-plugin-server: error while loading shared libraries: libswiftGlibc.so: cannot open shared object file: No such file or directory This PR depended on #71639, #71588, and #71685.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #71425, I hit an assert indicating the
@_sectionattribute was not handled inDeclDeserializer::deserializeDeclCommon. This change adds the missing deserialization for the@_sectionattribute.