Ncgenerics test fixes kavon v13 #71604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavon
force-pushed
the
ncgenerics-test-fixes-kavon-v13
branch
from
e70bdab to
608ff1b
Compare
|
@swift-ci smoke test |
1 similar comment
|
@swift-ci smoke test |
|
linux got aborted by my force-push and re-test. new run is here: https://ci.swift.org/job/swift-PR-Linux-smoke-test/11432/ |
kavon
force-pushed
the
ncgenerics-test-fixes-kavon-v13
branch
4 times, most recently
from
1fce960 to
f635d71
Compare
We were skipping the expansion of default requirements on generic parameters when creating an abstract generic signature that adds only new generic parameters, but no additional requirements.
kavon
force-pushed
the
ncgenerics-test-fixes-kavon-v13
branch
from
f635d71 to
e8b4813
Compare
When building a generic signature for a builtin function, do not infer Copyable and Escapable requirements. We should be explicit about what invertible protocols are required of the generic parameters for a builtin. This will require an audit of our existing Builtins to add the requirements as-needed, which is a task I'm deferring for now.
|
@swift-ci smoke test |
|
preset=ncgenerics,smoketest=macosx |
kavon
force-pushed
the
ncgenerics-test-fixes-kavon-v13
branch
from
61f0af9 to
d7a19f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moree fixes