Skip to content

Fix an IRGenDebugInfo type reconstruction error #71636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

hjyamauchi
Copy link
Contributor

This is the error:

Incorrect reconstructed type for $sSWxs5Error_pIgyrzo_D Original type:
(sil_function_type type="@NoEscape @callee_guaranteed (UnsafeRawBufferPointer) -> (@out \xCF\x84_0_0, @error any Error)"
(input=struct_type decl="Swift.(file).UnsafeRawBufferPointer")
(result=generic_type_param_type depth=0 index=0)
(error=existential_type
(protocol_type decl="Swift.(file).Error"))
(substitution_map null_generic_signature)
(substitution_map null_generic_signature))
Reconstructed type:
(sil_function_type type="@isolated(any) @NoEscape @callee_guaranteed (UnsafeRawBufferPointer) -> (@out \xCF\x84_0_0, @error Error)"
(input=struct_type decl="Swift.(file).UnsafeRawBufferPointer")
(result=generic_type_param_type depth=0 index=0)
(error=protocol_type decl="Swift.(file).Error")
(substitution_map null_generic_signature)
(substitution_map null_generic_signature))

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves #NNNNN, fix apple/llvm-project#MMMMM.

This is the error:

Incorrect reconstructed type for $sSWxs5Error_pIgyrzo_D
Original type:
(sil_function_type type="@NoEscape @callee_guaranteed (UnsafeRawBufferPointer) -> (@out \xCF\x84_0_0, @error any Error)"
  (input=struct_type decl="Swift.(file).UnsafeRawBufferPointer")
  (result=generic_type_param_type depth=0 index=0)
  (error=existential_type
    (protocol_type decl="Swift.(file).Error"))
  (substitution_map null_generic_signature)
  (substitution_map null_generic_signature))
Reconstructed type:
(sil_function_type type="@isolated(any) @NoEscape @callee_guaranteed (UnsafeRawBufferPointer) -> (@out \xCF\x84_0_0, @error Error)"
  (input=struct_type decl="Swift.(file).UnsafeRawBufferPointer")
  (result=generic_type_param_type depth=0 index=0)
  (error=protocol_type decl="Swift.(file).Error")
  (substitution_map null_generic_signature)
  (substitution_map null_generic_signature))
@hjyamauchi hjyamauchi requested a review from compnerd February 15, 2024 01:53
@hyp hyp requested a review from rjmccall February 15, 2024 02:26
@hyp
Copy link
Contributor

hyp commented Feb 15, 2024

added John since this is related to the recent @isolated(any) change

@rjmccall
Copy link
Contributor

Are you still seeing this after #71591?

@hborla
Copy link
Member

hborla commented Feb 15, 2024

@rjmccall I'm seeing this in Windows PR testing on #71643

@hjyamauchi
Copy link
Contributor Author

As @hborla reported, it looks like our windows toolchain build is still broken after #71591

@rjmccall
Copy link
Contributor

Alright, please check it with #71656.

@hjyamauchi
Copy link
Contributor Author

@rjmccall The new fix is working for me locally

@rjmccall
Copy link
Contributor

rjmccall commented Feb 15, 2024

I'm going to close this PR, which is not the right fix in any event. Please ping me on #71656 if it doesn't fix the problem for real. Sorry about this.

@rjmccall rjmccall closed this Feb 15, 2024
@hjyamauchi
Copy link
Contributor Author

Sure, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants