Move in-package resilience bypassing logic to a resilience check with accessing module #71663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isResilient(ModuleDecl, ResilienceExpansion). isResilient() returns the decl's resilience by definition and should not be altered whether bypassing optimization is enabled or not. The overloaded isResilient(ModuleDecl..) is used for accessing a decl from a client module, which is the appropriate place to opt in for non-resilience in package. Resolves rdar://123031292
|
@swift-ci smoke test |
…-bypass-resilience
|
@swift-ci smoke test |
elsh
changed the title
|
@swift-ci smoke test |
slavapestov
approved these changes
Feb 16, 2024
| getModuleContext()->inSamePackage(accessingModule) && | ||
| !getModuleContext()->isBuiltFromInterface() && | ||
| getFormalAccessScope(/*useDC=*/nullptr, | ||
| /*treatUsableFromInlineAsPublic=*/true).isPackage(); |
There was a problem hiding this comment.
I think you don't need the isPackage() check -- it should be safe to access public decls non-resiliently too across a package boundary.
There was a problem hiding this comment.
I'll push a separate PR for that.
CodaFi
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isResilient() returns the decl's resilience by definition and should not be altered whether resilience bypassing optimization is enabled or not. The overloaded isResilient(ModuleDecl, ResilienceExpansion) is used for accessing a decl from a client module, which is the appropriate place to check for in-package resilience bypass optimization.
Resolves rdar://123031292