Don't print conformance attributes redundantly in -preserve-types-as-written mode
#71687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…written. Since we no longer remove these attributes from the AttributedTypeRepr, if we print based on the TypeRepr, we'll print them twice. The best solution is to only print the attributes based on the inheritance clause if we're not printing the type based on the TypeRepr. Fixes rdar://122965951.
rjmccall
requested review from
hborla,
slavapestov,
xedin and
tshortli
as code owners
|
@swift-ci Please test |
tshortli
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we no longer remove these attributes from the
AttributedTypeRepr, if we print based on theTypeRepr, we'll print them twice. The best solution is to only print the attributes based on the inheritance clause if we're not printing the type based on theTypeRepr.Fixes rdar://122965951