-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[stdlib] Do not introduce any new ABI symbols for _get*RetainCount #71694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sensible to me.
@swift-ci test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but you will probably need to update the ABI checker 😉
D'oh, I definitely need to update it. |
@swift-ci test |
Oh this one has it too. |
@swift-ci test |
... |
@swift-ci test linux platform |
1 similar comment
@swift-ci test linux platform |
b972d2f
to
a35741f
Compare
@swift-ci test |
Oh this is unrelated & should be resolved now. |
@swift-ci test macOS platform |
There is no point to adding symbols for these, as they are only expected to be called interactively from lldb, which should handle @_aeic just fine.
rdar://120389342