Skip to content

[stdlib] Do not introduce any new ABI symbols for _get*RetainCount #71694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

lorentey
Copy link
Member

There is no point to adding symbols for these, as they are only expected to be called interactively from lldb, which should handle @_aeic just fine.

rdar://120389342

@lorentey lorentey requested a review from a team as a code owner February 16, 2024 23:32
Copy link
Contributor

@Catfish-Man Catfish-Man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible to me.

@lorentey
Copy link
Member Author

@swift-ci test

Copy link
Contributor

@Azoy Azoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but you will probably need to update the ABI checker 😉

@lorentey
Copy link
Member Author

D'oh, I definitely need to update it.

@lorentey
Copy link
Member Author

@swift-ci test

@lorentey
Copy link
Member Author

--- /Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-main/build/buildbot_incremental/swift-macosx-x86_64/test-macosx-x86_64/api-digester/Output/stability-stdlib-abi-with-asserts.test.tmp.tmp/stability-stdlib-abi.swift.expected.sorted	2024-02-17 02:31:51
+++ /Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-main/build/buildbot_incremental/swift-macosx-x86_64/test-macosx-x86_64/api-digester/Output/stability-stdlib-abi-with-asserts.test.tmp.tmp/changes.txt.tmp	2024-02-17 02:31:51
@@ -63,6 +63,9 @@
 Func _SequenceBox._map(_:) is now without @rethrows
 Func _collectReferencesInsideObject(_:) is a new API without @available attribute
 Func _diagnoseUnavailableCodeReached() is a new API without @available attribute
+Func _getRetainCount(_:) has been removed
+Func _getUnownedRetainCount(_:) has been removed
+Func _getWeakRetainCount(_:) has been removed
 Func _loadDestroyTLSCounter() is a new API without @available attribute
 Func _measureRuntimeFunctionCountersDiffs(objects:_:) is a new API without @available attribute
 Func _openExistential(_:do:) has been renamed to Func __abi_openExistential(_:do:)

Oh this one has it too.

@lorentey
Copy link
Member Author

@swift-ci test

@lorentey
Copy link
Member Author

/home/build-user/build/buildbot_linux/unified-swiftpm-build-linux-x86_64/x86_64-unknown-linux-gnu/release/Modules/SwiftDocC.swiftmodule:1:1: error: fatal error encountered while reading from module 'SwiftDocC'; please submit a bug report (https://swift.org/contributing/#reporting-bugs)

...

@lorentey
Copy link
Member Author

@swift-ci test linux platform

1 similar comment
@lorentey
Copy link
Member Author

@swift-ci test linux platform

@lorentey lorentey force-pushed the getRetainCount-mess branch from b972d2f to a35741f Compare February 27, 2024 21:18
@lorentey
Copy link
Member Author

@swift-ci test

@lorentey lorentey enabled auto-merge February 27, 2024 21:19
@lorentey
Copy link
Member Author

Failed Tests (1):
  Swift(macosx-x86_64) :: abi/macOS/x86_64/concurrency-asserts.swift

Oh this is unrelated & should be resolved now.

@lorentey
Copy link
Member Author

@swift-ci test macOS platform

@lorentey lorentey merged commit 0b5de06 into swiftlang:main Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants