[3.1] Sema: "super" calls to non-ObjC extension methods must be statically dispatched. #7172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dispatched. They currently can't ever show up in the vtable, so we must emit static calls to them. Fixes rdar://problem/30030229.
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: SILGen attempted to improperly emit a vtable dispatch when a subclass of an ObjC class attempted to
super-invoke an extension method from another module that wasn't@objc.Scope: Affects users trying to
super.-invoke methods from the SDK overlays in their custom subclasses of framework classes.Issue: rdar://problem/30030229
Risk: Low
Testing: Swift CI, test case from Radar