Skip to content

Test: allow one retry for flaky test #71746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Conversation

kavon
Copy link
Member

@kavon kavon commented Feb 20, 2024

this test fails occasionally, but it's not disabled. lit supports an ALLOW_RETRIES option, which is the number of times to re-reun the test after the first attempt fails (thus, ALLOW_RETRIES = 1 means the test is run at most twice). If a test passed only because of a retry, it'll be reported in the summary as a FLAKYPASS

@kavon kavon requested a review from ktoso as a code owner February 20, 2024 03:03
@kavon
Copy link
Member Author

kavon commented Feb 20, 2024

@swift-ci smoke test

@ktoso
Copy link
Contributor

ktoso commented Feb 20, 2024

Sounds like a good idea, thank you.

Can you file a radar/issue to investigate this again though please?

@kavon
Copy link
Member Author

kavon commented Feb 20, 2024

@swift-ci smoke test linux

@kavon kavon enabled auto-merge February 20, 2024 06:07
@kavon kavon merged commit 61cfce8 into swiftlang:main Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants