[CodeCompletion] Suggest static members on protocol extensions with Self bound in unresolved member lookup #71760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
requested review from
bnbarham,
hamishknight,
rintaro,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci Please smoke test |
slavapestov
reviewed
Feb 20, 2024
ahoppen
force-pushed
the
ahoppen/self-bound-extension
branch
from
f184baa to
0b5e00c
Compare
|
Thanks for the suggestions @slavapestov. Could you take another look at the updated code? |
|
@swift-ci Please smoke test |
slavapestov
reviewed
Feb 22, 2024
| extension MyProto where Self: MyOtherProto { | ||
| static var constrainedonMyInheritanceOfOtherProto: MyOtherProto { fatalError() } | ||
| } | ||
| extension MyProto where Self == MyOtherProto { |
There was a problem hiding this comment.
Shouldn't this be rejected? (Protocol doesn't self-conform)
There was a problem hiding this comment.
Yeah, but I still want to check that we don’t suggest it in code completion.
|
@swift-ci Please test Windows |
3 similar comments
|
@swift-ci Please test Windows |
|
@swift-ci Please test Windows |
|
@swift-ci Please test Windows |
rintaro
reviewed
Feb 29, 2024
| let _: MyProto = .#^ON_MY_PROTO^# | ||
| // ON_MY_PROTO: Begin completions, 1 items | ||
| // ON_MY_PROTO-DAG: Decl[StaticVar]/CurrNominal/TypeRelation[Convertible]: constrainedOnMyStruct[#MyStruct#]; | ||
| } |
There was a problem hiding this comment.
Could you add a test case for a case like
func testOpaqueMyProto() -> some MyProto {
return .#^HERE^#
}which doesn't seems work either currently.
There was a problem hiding this comment.
Oh, good idea. We handle it now.
…elf bound in unresolved member lookup rdar://122758029
ahoppen
force-pushed
the
ahoppen/self-bound-extension
branch
from
0b5e00c to
a176c07
Compare
|
@swift-ci Please smoke test |
rintaro
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://122758029