Skip to content

[IRGen] Make sure a C++ constructor thunk is called when it's needed #71790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

ahatanaka
Copy link
Contributor

This fixes a bug where the thunk for a C++ constructor call wasn't being called when the constructor was called the second time.

Copy link
Contributor

@egorzhdan egorzhdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@ahatanaka
Copy link
Contributor Author

@swift-ci please smoke test

This fixes a bug where the thunk for a C++ constructor call wasn't being
called when the constructor was called the second time.
@ahatanaka ahatanaka force-pushed the irgen-cxx-ctor-thunk branch from 29961e0 to 2cbf391 Compare February 22, 2024 00:47
@ahatanaka
Copy link
Contributor Author

@swift-ci please smoke test

@ahatanaka
Copy link
Contributor Author

@swift-ci please smoke test Windows

@swiftlang swiftlang deleted a comment from ahatanak Feb 22, 2024
@ahatanaka ahatanaka merged commit 97a8148 into main Feb 22, 2024
@ahatanaka ahatanaka deleted the irgen-cxx-ctor-thunk branch February 22, 2024 15:05
hjyamauchi added a commit to hjyamauchi/swift that referenced this pull request Nov 13, 2024
…wiftlang#71790)

This fixes a bug where the thunk for a C++ constructor call wasn't being
called when the constructor was called the second time.

Cherrypick commit 97a8148
Cherrypick PR swiftlang#71790
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants