[IRGen] Outlined value functions that destroy move-only-with-deinit types take and forward those types' metadata. #71799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation to sometimes use a metadata collector.
Made a function reasonably debuggable (type -> ty) and renamed misleading variable (formalType -> astType).
Some outlined functions call deinits for noncopyable values. These deinits require the metadata for the full type. Teach the OutliningMetadataCollector to collect the metadata for these types, when the new needsDeinit flag is set. Also add the new needsLayout flag. For now, all outlined functions need it.
Given a releasable value which contains a noncopyable value type with a deinit, that values outlined release function, among other things, must call the deinit of that noncopyable value type. In order to do that, its type metadata must be passed to the value function if it has an archetype.
nate-chandler
force-pushed
the
noncopyable-bugs/20240221/2
branch
from
c209f7b to
36b473d
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When it's needed (for outlined release and destroy functions) by outlined value functions, pass the metadata of generic, noncopyable value types with deinits that appear within the type's layout. Because the deinit takes the metadata for the type being destroyed itself, this is straightforward.