[region-isolation] Improve errors around strong transferring and wordsmith main error #71823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e is next to the routines that use the utility. NFC. Before this commit, the diagnostic emission was split into utilities that were used by one large emitter class. This could get confusing since there was some duplication of names in between the utilities. Now instead, each part of the main diagnostic emitter is in the MARK: section of the utilities that it uses. Just making the pass easier for me to reason about.
…essary. Just simplifying code. I also deleted dead code as well.
…ansfer non transferrable error. Preparing for beginning to emit named errors where I need this information. This just lets me do it before that other commit to make it cleaner. NFC.
I just did a full pass through. There were some cases around nonisolated closures defined in methods and global actor isolated things where we are now emitting the wrong message. I am going to fix that in subsequent commits.
…uld,may} cause a race" As I was updating tests in the previous commit, I noticed that this would read better to me.
…nfer name/root from value. This just cleans up the code by not exposing the details from the VariableNameInferrer outside of the utilities. It also makes it easier to write conditional code that uses these helpers by returning an optional, so instead of having a long setup + an if statement, we just have an if statement optional check.
…ssigned into a different transferring parameter. Just eliminating another "call site passes `self`" error.
…mit better diagnostics given the new support I added for VariableNameInference.
gottesmm
requested review from
ktoso,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series of commits:
selferror. Still a little more to do, but this hits most of them.